Credo v1.4.0 Credo.Check.Warning.UnusedStringOperation View Source

This check has a base priority of high and works with any version of Elixir.

Explanation

The result of a call to the String module's functions has to be used.

While this is correct ...

def salutation(username) do
  username = String.downcase(username)

  "Hi #{username}"
end

... we forgot to save the downcased username in this example:

# This is bad because it does not modify the username variable!

def salutation(username) do
  String.downcase(username)

  "Hi #{username}"
end

Since Elixir variables are immutable, String operations never work on the variable you pass in, but return a new variable which has to be used somehow.

Configuration parameters

There are no parameters for this check.

Link to this section Summary

Link to this section Functions

Link to this function

run(source_file, params \\ [])

View Source